Prabhu Jha (Progress Software) asked a question.
The source files of the OpenEdge 12.8.9 and 12.2.18 AppBuilder product that were included in OpenEdge Update commercial shipment is available now in GIT.
https://github.com/progress/ADE/tree/v12.8.9.0
https://github.com/progress/ADE/tree/v12.2.18.0
If you wish to share something that you develop using this code, please submit it to OpenEdge Code Share. Progress does not make any commitment to include changes in future code drops.
Files that got modified in OE 12.8.9 are:
corelib/OpenEdge/Logging/Format/LogMessageTokenResolver.cls
netlib/OpenEdge/Web/DataObject/DataObjectService.cls
netlib/OpenEdge/Web/DataObject/Writer/OpenAPI30ServiceWriter.cls
Files that got modified in OE 12.2.18 are:
adedict/IDX/_idxprop.p
adedict/IDX/_saveidx.p
adeicon/u-logo.bmp
corelib/OpenEdge/Core/TimeStamp.cls
netlib/OpenEdge/Mobile/ApperyPushNotificationMessageBuilder.cls
netlib/OpenEdge/Mobile/KinveyPushNotificationMessageBuilder.cls
netlib/OpenEdge/Mobile/TelerikPushNotificationMessageBuilder.cls
netlib/OpenEdge/Net/HTTP/DefaultRequestBuilder.cls
netlib/OpenEdge/Net/HTTP/Filter/Payload/ClientSocketResponseWriter.cls
netlib/OpenEdge/Net/MultipartEntity.cls
netlib/OpenEdge/Web/DataObject/DataObjectService.cls
prodict/user/_usrichg.p
@Prabhu Jha (Progress Software)
I notice that some sources that were previously readable are now encrypted.
e.g. dump/_lod_raw.i is is readable in v12.8.6.0 but encrypted in the current version
https://github.com/progress/ADE/blob/d85b3f346aa92bb35c30365e2eacee68eeff19dd/prodict/dump/_lod_raw.i
https://github.com/progress/ADE/blob/0c0a0294f23ce6d93071595647294176828ba490/prodict/dump/_lod_raw.i
Hi @Carl Verbiest (CCE NV),
There are a few include files that are shipped as part of OpenEdge product as xcoded. We decided to post them publicly in the same format.
Here is the list of files that are xcoded now:
src/adecomm/_isfld.i
src/adecomm/_istbl.i
src/prodict/dump/_lod_raw.i
src/prodict/dump/loaddefs.i
src/prodict/misc/_rundift.i
src/prodict/misc/_rundump.i
src/prodict/misc/_runload.i
src/prodict/misc/_runsylk.i
src/prodict/ora/_runload.i
Thanks,
Talha
Hi Talha,
any info on what triggered this decision ? Is there a post on CVP related to this ?
Hello Carl,
Recently, we’ve had internal discussions regarding the maintenance of xcoded include files and the basic functionality they provide. Many of these include files contain logic that can now be simplified or replaced using newer features available in ABL.
As part of an upcoming initiative, we plan to remove references to most of these xcoded include files from the ADE source code. During my research for this effort, I identified an inconsistency, the same include files exist in two different locations but with varying formats. To address this, we’ve decided to standardize the format across both locations for consistency and maintainability.
Please feel free to reach out if you have any questions. I’d be happy to provide more details.
Thanks,
Talha
@Talha Masood (Progress Software)
Why put in the effort to encrypt these sources If you plan to remove them.
Just removing them will be a much clearer signal to people that rely on these sources than encrypting them.
I don't really care about these particular sources, but having access to the source has enabled me
Hi Carl,
I believe that's the idea behind publishing the source code, to enable users to access the features available in the ADE source code.
My thoughts, removing them from the git repo now will bring the inconsistency. Instead, we maintain the include files in the same format across both places(DLC & Git) until the references are removed.
Please let me know your feedback/comment.
Thanks,
Talha
SO basically you're encrypting the code to mark it as deprecated. That's really weird. Just add a comment at the top of the file and leave that to our responsibility if we keep on using this or not.
Hi Mike,
We xcoded those files to ensure consistent code is maintained across both the OpenEdge DLC and the Git repository.
Thanks,
Talha
This was discussed here previously:
https://community.progress.com/s/question/0D5Pb00002lcHHXKA2/additional-ade-source-code-now-xcoded