After the processor library finishes processing a record, if it returns an error to replProc.p the logError procedure is called, which creates/modifies a record in the Pro2.ReplP_ThreadErrors table.  The code is not in a tightly scoped transaction which causes subsequent share locks to raise the transaction scope.

This results in slower performance and potential lock wait scenarios.

 

The code in logError that interacts with the Pro2.ReplP_ThreadErrors record should be surrounded with a TRANSACTION block to contain the transaction.

 

None at this time.

 

Make a copy of replProc.p in <pro2-dir>\custom\bprepl and surround the transactional code in the logError internal procedure with a TRANSACTION block.

At the time of this writing (Pro2 6.5.2) the code change looks like below:

FIND FIRST {&Pro2DB}ReplP_ThreadErrors WHERE DATE({&Pro2DB}ReplP_ThreadErrors.CREATEDATE) = TODAY AND 
        {&Pro2DB}ReplP_ThreadErrors.THREADTYPE = "REPLICATION" AND
        {&Pro2DB}ReplP_ThreadErrors.THREADID   = ip_thread_num NO-LOCK NO-ERROR.
DO TRANSACTION ON ERROR UNDO, LEAVE:        
    IF NOT AVAILABLE({&Pro2DB}ReplP_ThreadErrors) THEN DO:
        CREATE {&Pro2DB}ReplP_ThreadErrors.
        ASSIGN {&Pro2DB}ReplP_ThreadErrors.THREADERRORID = NEXT-VALUE(ThreadErrorSeq) 
               {&Pro2DB}ReplP_ThreadErrors.S_RELID = 0 /*tseqid*/
               {&Pro2DB}ReplP_ThreadErrors.THREADID = ip_thread_num
               {&Pro2DB}ReplP_ThreadErrors.THREADTYPE = "REPLICATION"
               {&Pro2DB}ReplP_ThreadErrors.ERRORDESCRIPTION = strErrMsg
               {&Pro2DB}ReplP_ThreadErrors.CREATEDATE = TODAY 
               {&Pro2DB}ReplP_ThreadErrors.ERRORCOUNT = 1.  
    END.
    ELSE DO:
        FIND CURRENT {&Pro2DB}ReplP_ThreadErrors EXCLUSIVE-LOCK NO-ERROR.
        IF AVAILABLE({&Pro2DB}ReplP_ThreadErrors) THEN 
            {&Pro2DB}ReplP_ThreadErrors.ERRORCOUNT = {&Pro2DB}ReplP_ThreadErrors.ERRORCOUNT + 1.        
    END.
END.