How to use RedirectToAction and Url.Action in MVC Classic mode

Jul 18, 2016
Knowledge

Title

URL Name

How-to-use-RedirectToAction-and-Url-Action-in-MVC-Classic-mode

Article Number

000187884

Environment

Product: Sitefinity Version: 8.x, 9.x OS: All supported OS versions Database: Microsoft SQL Server 2012 SP2

Question/Problem Description

In MVC Classic mode route helper methods like RedirectToAction, Url.Action, Action.Link etc. are not generating correct routes.

The incorrect route is /Sitefinity/Themes?action={action}&controller={controller} .

Steps to Reproduce

Clarifying Information

Steps to replicate

1. Create a controller
2. Create an action that uses RedirectToAction
3. Create an action that uses Url.Action
4. Register a custom classic route
5. Call the action from step 2 through the classic route
6. Call the action from step 3 and check the generated url
Expected behavior: the generated location must be /{controller}/{action}/{params}

Error Message

Defect Number

185388

Enhancement Number

Cause

The problem seems to be caused by the way RedirectToAction() and Url.Action() methods work in ASP.NET MVC. They iterate through all the routes in the route table and find the first match. But, if a route has no defined {controller} and {action} url parameters it is considered a match and used for url generation with the controller and action values sent in the query string. This means that by design these helper methods along with @html.ActionLink() rely on the presumption that all the routes in the route table are designed with MVC in mind. But this is not the case in Sitefinity architecture where routes exist that have no {controller} url parameters and no default controllers set.

For more information about Bug 185388 , see https://feedback.telerik.com/Project/153/Feedback/Details/185388

Resolution

No resolution refer to the workaround.

Workaround

Classic Mode routes should be added to the top of the routing table with unique route prefix. Unique route prefix is needed to prevent braking Sitefinity routes resolution. Route constraints could also be added to minimize the risk of interference with Sitefinity routes.

There are two ways to register a route at the top of the routing table. Both include registering routes in the Global.asax.cs file. In the provided examples “uniquePrefix” prefix is used. It is mandatory that a unique prefix is used.

By using MapRoute extension method of the RoutesCollection object that is provided by ASP.NET MVC. The method returns the created RouteBase object which we can use to remove and reinsert at a specified position in the route collection. This has the advantage of creating a named route.

using System.Web.Routing;
using System.Web.Mvc;

protected void Application_Start(object sender, EventArgs e)

{

Bootstrapper.Initialized += Bootstrapper_Initialized;

}

void Bootstrapper_Initialized(object sender, Telerik.Sitefinity.Data.ExecutedEventArgs e)

{

if (e.CommandName == "Bootstrapped")

{

var routes = RouteTable.Routes;

Route r = routes.MapRoute(

"Pref", // Route name

"uniquePrefix/{controller}/{action}", // URL with parameters

new { controller = "Default", action = "Index" } // Parameter defaults

);

routes.Remove(r);

routes.Insert(0, r);

}

2. By manually creating the route and inserting it in the route collection. This method has no way to create a named route.

using System.Web.Routing;

protected void Application_Start(object sender, EventArgs e)

{

Bootstrapper.Initialized += Bootstrapper_Initialized;

}

void Bootstrapper_Initialized(object sender, Telerik.Sitefinity.Data.ExecutedEventArgs e)

{

if (e.CommandName == "Bootstrapped")

{

var routes = RouteTable.Routes;

var url = " uniquePrefix/{controller}/{action}";

var defaults = new RouteValueDictionary(new { controller = "Default", action = "Index" });

Route route = new Route(url, defaults, new MvcRouteHandler());

routes.Insert(0, route);

}

Notes

The amount of votes an item in the feedback portal has is taken into consideration when determining its priority. Vote for the item using the Like and Dislike buttons in the right-hand side menu to affect the priority it has. By casting a vote the voter will also be subscribed to a mailing list to receive notifications about changes of the item such as when it is fixed or implemented.

Keyword Phrase

Last Modified Date

10/12/2017 7:56 AM

How to use RedirectToAction and Url.Action in MVC Classic mode

Files(0)

Was this article helpful?

Was this article helpful?

How to use RedirectToAction and Url.Action in MVC Classic mode

Information

Related Articles